Skip to content

ZA-ITP-MAY-2025 | ALIZIWE_NGOMA | MODULE-ONBOARDING | WEEK1 #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ZA-ITP-MAY-2025 | ALIZIWE_NGOMA | MODULE-ONBOARDING | WEEK1 #256

wants to merge 5 commits into from

Conversation

Aliziwe
Copy link

@Aliziwe Aliziwe commented Feb 8, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@netlify Netlify
Copy link

netlify bot commented Feb 8, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit cc0bc8b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/682af51131c9e800089db7bf
😎 Deploy Preview https://deploy-preview-256--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Aliziwe Aliziwe marked this pull request as draft February 17, 2025 21:08
@Aliziwe Aliziwe marked this pull request as ready for review February 17, 2025 21:10
@Aliziwe Aliziwe marked this pull request as draft February 19, 2025 20:17
@Aliziwe Aliziwe marked this pull request as ready for review February 19, 2025 20:20
@Aliziwe Aliziwe marked this pull request as draft February 19, 2025 20:21
@Aliziwe Aliziwe added the Needs Review Participant to add when requesting review label Feb 24, 2025
@Aliziwe Aliziwe marked this pull request as ready for review February 24, 2025 08:40
@A-O-Emmanuel A-O-Emmanuel added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 26, 2025
A-O-Emmanuel
A-O-Emmanuel reviewed Feb 26, 2025
View reviewed changes
Form-Controls/index.html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay, good job!

A-O-Emmanuel
A-O-Emmanuel reviewed Feb 26, 2025
View reviewed changes
Wireframe/index.html
Copy link

@A-O-Emmanuel A-O-Emmanuel Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should take another look at the wireframe, the page title and description should be centered and the footer also needs to be centered. you also need to work on your indentation and spacing please look at this article: How to indent your HTML code and why it's important

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've taken another look and I've done as suggested. Thank you for the article.

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 26, 2025
@Aliziwe Aliziwe mentioned this pull request Feb 26, 2025
Open
@OracPrime OracPrime removed the Needs Review Participant to add when requesting review label Mar 3, 2025
@Aliziwe Aliziwe added the Needs Review Participant to add when requesting review label May 20, 2025
@Aliziwe Aliziwe changed the title ITP-JAN | ALIZIWE_NGOMA | MODULE-ONBOARDING | WEEK1 ZA-ITP-MAY-2025 | ALIZIWE_NGOMA | MODULE-ONBOARDING | WEEK1 May 21, 2025
@Aliziwe Aliziwe removed the Reviewed Volunteer to add when completing a review label May 21, 2025
@cjyuan
Copy link
Contributor

cjyuan commented May 23, 2025

@A-O-Emmanuel @Aliziwe
Each exercise/project should be prepared in separate branches and submitted in separate PRs.

Aliziwe, I see that you have another branch named feature/wireframe. Can you prepare your implementation of the Wireframe exercise in that branch, and then submit a separate PR for your Wireframe exericse?

After that, can you make this branch clean so that this branch contains only modified files related to the Form-Control exercise?

@Waldo-Strydom Waldo-Strydom added 👀 Review Git Changes requested to do with Git 👀 Review Requirements Changes requested to meet requirements and removed Needs Review Participant to add when requesting review labels May 24, 2025
@Aliziwe
Copy link
Author

Aliziwe commented May 28, 2025

@cjyuan , thank you for your feedback. I've created a separate PR for my wireframe changes. However, I don't know how to clean this one up so that it only presents information that corresponds with form-control requests. Please provide suggestions on how to do this.

@cjyuan
Copy link
Contributor

cjyuan commented May 28, 2025

@Aliziwe Here is one way to restore the modified unrelated files.

  1. Switch to this branch in your VSCode or using git command
  2. In your browser, visit your main branch of this repo (https://github.com/Aliziwe/Module-Onboarding/tree/main)
  3. Replace the modified unrelated files in this branch (two of them) by the same files in your main branch.
    • You can copy/paste the file content or you can download the raw file.
  4. Commit your change (replacement of two files).
  5. Push your changes to Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-O-Emmanuel A-O-Emmanuel A-O-Emmanuel left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
👀 Review Git Changes requested to do with Git 👀 Review Requirements Changes requested to meet requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aliziwe @cjyuan @A-O-Emmanuel @OracPrime @Waldo-Strydom